search

sinonjs / fake-timers

Fake setTimeout and friends (collectively known as "timers"). Useful in your JavaScript tests. Extracted from Sinon.JS
BSD 3-Clause "New" or "Revised" License
793 stars 103 forks source link

fixes invalid use of arguments in strict mode error #484

Closed yaruno closed 8 months ago

yaruno commented 8 months ago

Purpose (TL;DR) - mandatory

Fix typescript error T1100 which complains about invalid use of term 'arguments' in strict mode.

Solution - optional

Use args instead of arguments in annotation.

Näyttökuva 2023-10-18 133619 Näyttökuva 2023-10-18 133446
fatso83 commented 8 months ago

thanks!

yaruno commented 8 months ago

Any timeline for the next release of this library? Would love to get this fix into npm and to our production :)

fatso83 commented 8 months ago

We are not shipping a typescript library and as such you should configure your tsconfig.json to ignore checking this library. So strictly speaking, issues in our Jsdoc caught by TSC is not an error, but I can ship a new version regardless, since #479 is not released yet 😄