Feature detect Object.getOwnPropertySymbols

[mantoni]

Purpose (TL;DR) - mandatory

This fixes an IE 11 regression introduced in #26. Object.getOwnPropertySymbols is not supported in all environments.

How to verify - mandatory

1. Check out this branch
2. npm install
3. npm t

Checklist for author

• [x] npm run lint passes
• [x] References to standard library functions are cached.

[coveralls]

Pull Request Test Coverage Report for Build 108

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 8 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.2%) to 82.243%

---

Files with Coverage Reduction	New Missed Lines	%
formatio.js	8	82.24%
<!--	Total:	8		-->

Totals
Change from base Build 105:	-0.2%
Covered Lines:	95
Relevant Lines:	113

---

💛 - Coveralls

[BrandonE]

I have the same issue with code coverage on my PR now. What is your suggestion for handling this, @mantoni? Should we actually use sinon to stub getOwnPropertySymbols to undefined for this test case?

[mantoni]

No. That'd be cheating just for the statistics. If we want to increase coverage for these cases, we'd have to use Mochify and run tests in headless chrome and generate the coverage report there instead of on node.

[BrandonE]

Do you recommend using Mochify or changing the threshold? I plan on applying whatever change you make here to my PR.

[mantoni]

We don't have a treshold configured. It just marks any coverage decrese as a potential issue, I think. So I'm not directly planning to do anything about it 😄

[BrandonE]

Currently, the build checks are failing. Is the plan to override them and just merge?

[mantoni]

The build checks don't prevent merging. I see coverage information as hint. If it drops dramatically, there's something wrong. It's not a hard requirement to always keep the previous value up.

[mantoni]

Released in v3.2.1.