search

sinonjs / sinon

Test spies, stubs and mocks for JavaScript.
https://sinonjs.org/
Other
9.63k stars 769 forks source link

Proposal: publish to npm using scopes #1652

Open mroderick opened 6 years ago

mroderick commented 6 years ago

I think it would make sense to start using scopes when we publish things to npm.

mantoni commented 6 years ago

Yes that would be nice and consistent with GitHub. It also gives us more freedom with naming future modules 👍

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

fatso83 commented 5 years ago

How do we notify people of the naming change? Most people are probably used to adding sinon to a project using npm install sinon. That will make them stay at an older release. Maybe the last major version change should just be that each require call now outputs sinon has moved to the @sinonjs/sinon namespace. Please change your package.json dependency accordingly.?

mgred commented 5 years ago

How do we notify people of the naming change?

I think we should communicate as soon as possible with a note on the website/documentation and the README.md in all the projects that there will be a scoped package name structure from version x.0.0.

That will make them stay at an older release

Furthermore we should publish a deprecation notice on npm, e.g. CoffeScript is doing this: https://www.npmjs.com/package/coffee-script (1.x) https://www.npmjs.com/package/coffeescript (2.x)

When you run npm install coffee-script, there will be a notice saying: CoffeeScript on NPM has moved to "coffeescript" (no hyphen)

I have no experience with npm but, npm-depricate seems worth a look.

Maybe the last major version change should just be that each require call now outputs sinon has moved to the @sinonjs/sinon namespace. Please change your package.json dependency accordingly.?

:smile: I like this. When we log a message everytime sinon is required then I think users quickly update their dependecies

mroderick commented 5 years ago

Deprecating packages is not that difficult, I've already done it when we adopted referee, samsam and formatio.

mantoni commented 5 years ago

Issue for nise: https://github.com/sinonjs/nise/issues/77

fatso83 commented 3 years ago

This is only missing for sinon.