search

sinonjs / sinon

Test spies, stubs and mocks for JavaScript.
https://sinonjs.org/
Other
9.66k stars 769 forks source link

Fix Safari Sauce Labs test runner #2372

Open fatso83 opened 3 years ago

fatso83 commented 3 years ago

Our integration-tests pipeline in CircleCI has been failing for two months. This happened when introducing "safari" without explicit version (was version 9). Logs show that we have been trying to do this earlier as well. Basically, our npm run test-cloud script fails for any Safari version > 9.

Example: https://app.circleci.com/pipelines/github/sinonjs/sinon/572/workflows/79f646b4-553b-4ed7-a622-b585860850ef/jobs/4557/parallel-runs/0/steps/0-102

Overview of builds: https://app.circleci.com/pipelines/github/sinonjs/sinon?branch=master

To reproduce, checkout master, set the sauce labs username and key and run the script. It will fail with a general HTTP 500. These things are generally near impossible to debug, so I have filed a support request. No too hopeful.

Addendum When we have a config that actually can run our tests we need to re-add Safari. Was removed in https://github.com/sinonjs/sinon/commit/ecad8a8e30d431d1a97a44e2c36bc6a8ff460aa5

fatso83 commented 3 years ago

Houston, we have contact! The Sauce Labs team responded in a few hours.

Screenshot_20210513_073421_com.google.android.gm.jpg

So it seems this is a mochify or min-wd thing. @mantoni is probably the only one to know about these things. The whole webdriver thing and configuration is a bit opaque to me.

fatso83 commented 3 years ago

Created https://github.com/mantoni/min-webdriver/issues/31. This seems quite doable.

fatso83 commented 3 years ago

I fiddled around with this for almost two hours without getting anywhere ...

stale[bot] commented 11 months ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.