search

sinonjs / sinon

Test spies, stubs and mocks for JavaScript.
https://sinonjs.org/
Other
9.63k stars 769 forks source link

Overly specific CSS selectors mess up the Changelog styling on sinonjs.org #2469

Closed fatso83 closed 1 year ago

fatso83 commented 2 years ago

Describe the bug The styling of our Changelog is messed up. Lack of a proper styling approach like BEM ensures style rules are applied with a shotgut.

image

This is caused by selectors such as these, that target stuff they should not image

To Reproduce

  1. Go to https://sinonjs.org/releases/changelog.
  2. See the changelog entries for version 14.0.0 and 13.0.2
  3. Observe that author links get display: block and blockquotes get font-size 24 instead of 16.

Expected behavior Shit should look good. No block display for inline elements such as a tags and the block quotes should not be centered and have font size 24.

mroderick commented 2 years ago

This doesn't look very fixed on my screen:

2022-08-29 at 17 16

leolupianez commented 2 years ago

Does the live site have the latest changes?

fatso83 commented 2 years ago

That only happens when we push a new version, actually.

aushwin commented 1 year ago

I think I will be able to fix the issue . New to open source by the way ! Can you assign it to me ?

fatso83 commented 1 year ago

We have just forgotten to close this after #2470 was merged :smile_cat: . But thanks! Otherwise our CONTRIBUTING.md should get you started.

image