sinonjs / sinon

Test spies, stubs and mocks for JavaScript.
https://sinonjs.org/
Other
9.63k stars 769 forks source link

Un-pin @sinonjs/fake-timers #2495

Closed elwayman02 closed 1 year ago

elwayman02 commented 1 year ago

Purpose (TL;DR)

The commit upgrading from v9 to v10 appears to have accidentally dropped the caret from the version range, pinning it to a single version: https://github.com/sinonjs/sinon/commit/aa493da47d788025c0d512696651072973f301ec

Un-pinning the version will allow sinon and its consumers to automatically pick up new in-range versions of @sinonjs/fake-timers as they're released in the future.

How to verify

  1. Check out this branch
  2. npm install
  3. Latest version of @sinonjs/fake-timers should still be installed

Checklist for author

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (45be60f) 95.95% compared to head (e4150a3) 95.95%.

:exclamation: Current head e4150a3 differs from pull request most recent head ad8b46e. Consider uploading reports for the commit ad8b46e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2495 +/- ## ======================================= Coverage 95.95% 95.95% ======================================= Files 38 38 Lines 1878 1878 ======================================= Hits 1802 1802 Misses 76 76 ``` | Flag | Coverage Δ | | |---|---|---| | unit | `95.95% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

fatso83 commented 1 year ago

Ooh, thanks for picking that up!

fatso83 commented 1 year ago

published as sinon 15.0.2