sinonjs / sinon

Test spies, stubs and mocks for JavaScript.
https://sinonjs.org/
Other
9.61k stars 769 forks source link

Only force new or inherited descriptors to be configurable #2515

Closed fatso83 closed 1 year ago

fatso83 commented 1 year ago

Purpose (TL;DR) - mandatory

Fixes the regression introduced in 15.0.4 and documented as #2514.

Regression test added.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b2a4df5) 95.99% compared to head (acd205a) 96.00%.

:exclamation: Current head acd205a differs from pull request most recent head a6333f4. Consider uploading reports for the commit a6333f4 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2515 +/- ## ======================================= Coverage 95.99% 96.00% ======================================= Files 40 40 Lines 1899 1900 +1 ======================================= + Hits 1823 1824 +1 Misses 76 76 ``` | Flag | Coverage Δ | | |---|---|---| | unit | `96.00% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/sinonjs/sinon/pull/2515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs) | Coverage Δ | | |---|---|---| | [lib/sinon/util/core/wrap-method.js](https://app.codecov.io/gh/sinonjs/sinon/pull/2515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs#diff-bGliL3Npbm9uL3V0aWwvY29yZS93cmFwLW1ldGhvZC5qcw==) | `82.52% <100.00%> (+0.17%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.