Closed bojavou closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
05f05ac
) 96.00% compared to head (da60bbf
) 96.00%.:exclamation: Current head da60bbf differs from pull request most recent head be30ce0. Consider uploading reports for the commit be30ce0 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thank you! I'll be glad to switch back to mainline.
Purpose (TL;DR) - mandatory
Support callable instances Closes #2516
Background (Problem in detail)
Enables testing constructors that return functions. #2516 has further description.
Solution - optional
The constructor return value seems to be checked in
proxy-invoke.js
. This expands thetypeof
check to include functions.This works for my code in a local patched version. Tests are included to verify.
How to verify - mandatory
npm install
npm test
You can verify manually by running this code from the checkout root. Output should be
true
.Checklist for author
npm run lint
passes