Closed MrChocolatine closed 10 months ago
Patch and project coverage have no change.
Comparison is base (
baa1aee
) 95.95% compared to head (83ce3a9
) 95.95%.:exclamation: Current head 83ce3a9 differs from pull request most recent head 53320b1. Consider uploading reports for the commit 53320b1 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks!
Purpose (TL;DR)
This PR follows #2539 and fixes the example that defines a non-function property when using
.define()
.Solution
This fixes works by following the tests of
.define()
: https://github.com/sinonjs/sinon/blob/baa1aee9e5766ff1bfcbc62d81ddaf3138174c54/test/sandbox-test.js#L819-L833How to verify
npm install
npm test
Checklist for author
npm run lint
passes