sinonjs / sinon

Test spies, stubs and mocks for JavaScript.
https://sinonjs.org/
Other
9.61k stars 769 forks source link

Suggestions for #2540 #2551

Closed mroderick closed 10 months ago

mroderick commented 10 months ago

These are suggestions for #2540

I made a PR to make it easier to cherry pick the suggestions.

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (docs-how-to@492a09e). Click here to learn what that means.

:exclamation: Current head b6f692d differs from pull request most recent head 924555f. Consider uploading reports for the commit 924555f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## docs-how-to #2551 +/- ## ============================================== Coverage ? 95.73% ============================================== Files ? 40 Lines ? 1901 Branches ? 0 ============================================== Hits ? 1820 Misses ? 81 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/sinonjs/sinon/pull/2551/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/sinonjs/sinon/pull/2551/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs) | `95.73% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fatso83 commented 10 months ago

Applied all! thank you 😗