sinonjs / sinon

Test spies, stubs and mocks for JavaScript.
https://sinonjs.org/
Other
9.6k stars 769 forks source link

breaking: Remove sinon.defaultConfig and related modules #2565

Closed fatso83 closed 8 months ago

fatso83 commented 8 months ago

default-config and get-config are leftovers from when Sinon shipped with sinon.test (now the independent NPM module 'sinon-test').

These serve no purpose internally, and really have no purpose but to help sinon-test create a base default. If needed, these can be copied into the sinon-test project. No projects should depend on these (my assumption), but since it is a change of the API we mark it as a breaking change

When working with these I found out that some things had never been documented, so added docs for that.

fixes #2561

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b5fc367) 96.05% compared to head (441daf4) 96.05%.

:exclamation: Current head 441daf4 differs from pull request most recent head 94ee6d3. Consider uploading reports for the commit 94ee6d3 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2565 +/- ## ========================================== - Coverage 96.05% 96.05% -0.01% ========================================== Files 41 40 -1 Lines 1928 1927 -1 ========================================== - Hits 1852 1851 -1 Misses 76 76 ``` | [Flag](https://app.codecov.io/gh/sinonjs/sinon/pull/2565/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/sinonjs/sinon/pull/2565/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs) | `96.05% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/sinonjs/sinon/pull/2565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs) | Coverage Δ | | |---|---|---| | [lib/create-sinon-api.js](https://app.codecov.io/gh/sinonjs/sinon/pull/2565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs#diff-bGliL2NyZWF0ZS1zaW5vbi1hcGkuanM=) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.