Closed 1bberto closed 1 month ago
We've been blocked by this issue, too. I noticed that the issue is caused by https://github.com/sinonjs/nise/pull/216. Rewriting all the usages of respondWith
is a pain for us, but reading https://github.com/sinonjs/nise/pull/216, this seems to be an intended breaking change.
Thanks for providing this. This bug is totally on me. I am not sure how I missed James' very detailed explanations in his PR, which spells out how this is a breaking change and actually asks for input (which I also missed, must have been late).
My suggestion:
Thoughts, @43081j or @mroderick ?
An interim "fix" is that I rolled the latest
tag to point to 17.0.1. Wiping node_modules should be sufficient.
i think that makes sense. let me know if you want any help sorting the new flag out etc
doesn't sound too difficult. basically default it to legacy behaviour which auto-escapes ?
under the hood
The code repro is unfortunately not runnable (suggest using RunKit next time), so I have no 100% assurance this is fixed, but it should be fixed in the changes James shipped to Nise (enabling the legacy routes flag by default) should mean this is gone. Please test Sinon 18 and report back if this is not fixed.
Describe the bug the
respondWith
seems to not work when the URL has a?
To Reproduce Steps to reproduce the behavior:
I have this
the code is breaking when
server.respondWith
is being calledthe error is
Context (please complete the following information):