sandbox.useFakeXMLHttpRequest is server instead of xhr

[Krinkle]

This seems rather confusing, was this on purpose or is this a bug?

lib/sinon/sandbox.js#L120:

    sinon.sandbox.useFakeXMLHttpRequest = sinon.sandbox.useFakeServer;

As a result, code like the following (based on sinon-qunit documentation) doesn't actually work:

QUnit.test('example', function (assert) {
    var xhr = this.sandbox.useFakeXMLHttpRequest(),
        requests = [];

    xhr.onCreate = function (request) {
        requests.push(request);
    };

    $.getJSON('/test');
    assert.equal(this.requests.length, 1);

    requests[0].respond(200, { 'Content-Type': 'application/json' }, '{}');
});

.. because that attaches a spurious onCreate method to the server object. The fake xhr manager is actually in xhr.xhr and the code is fixed when changed to xhr.xhr.onCreate = function () { .. }.

[n1k0]

Stumbled upon the same issue. Would be really nice to fix the API, or at the very least to update the docs…

[jtruelove]

I am seeing something similar

[cjohansen]

That does indeed look strange. I can't really remember the reasoning behind this, but I am open to fix it. Sinon has 80 contributors, more are always welcome ;)

[renatewr]

Hi! Is ther any new version fixing this issue?

[gabrieledarrigo]

Hi, even the new version use this:

sinon.sandbox.useFakeXMLHttpRequest = sinon.sandbox.useFakeServer;

?