sinoroc / tox-poetry-dev-dependencies

Tox plugin to help working with Poetry-based projects
https://pypi.org/project/tox-poetry-dev-dependencies/
Apache License 2.0
15 stars 3 forks source link

Fix TypeError under Python 3.5 #4

Closed mikenerone closed 4 years ago

mikenerone commented 4 years ago

Fixes #3

sinoroc commented 4 years ago

Theoretically we should adjust the CI, etc. so that we test against Python 3.5 as well. But from a quick first try, seems like it would bring other breakages (with pytest-yapf3). But since the code change is so small maybe we could simply take the change without advertising Python 3.5 compatibility. It would be compatible by coincidence.

sinoroc commented 4 years ago

Since I host the code on both GitHub and GitLab (and who knows where the code will land later on), I want to have elements of the commit messages that refer to a specific platform prefixed accordingly. It makes things clearer anyway. Something like:

Fix TypeError under Python 3.5

GitHub: fixes #3

Would you mind doing that?

mikenerone commented 4 years ago

Of course, done. :)

mikenerone commented 4 years ago

But from a quick first try, seems like it would bring other breakages (with pytest-yapf3).

Perhaps you could exclude the yapf checks for the 3.5 run. Side note: I look forward to not using 3.5 myself and not caring about this. :D But for the moment, you know, constraints.

sinoroc commented 4 years ago

Of course, done. :)

Thanks.

Perhaps you could exclude the yapf checks for the 3.5 run.

Yes. I have been meaning to revamp the whole thing for a while now, since there is no reason to do the whole linting, typing, formatting, etc. for each Python version (sometimes they even contradict each other). Once it's done, I will think about activating Python 3.5 in the CI.

I look forward to not using 3.5 myself and not caring about this. :D But for the moment, you know, constraints.

I get it. If it is truly needed then I will try to get the change in and publish a new release quickly.

mikenerone commented 4 years ago

Many thanks!