Closed shur1k closed 2 years ago
Hello @shur1k shur1k! Thank you for your contribution. I will take this as an opportunity to revise the entire example, since other functions have not yet been implemented.
For the sake of completeness:
Alexa uses the color temperatures 2200, 2700, 4000, 5000 and 7000.
So I am still missing the RGB values for 2200, 4000 and 7000.
Can you give me these values or your source for converting the color temperature to RGB values?
I found a source for converting color temperatures to RGB values and it looks like it uses the same values as you.
I have finished the new example.
It would be very nice if you could test it before I add it to the library.
Thank you for a quick response @sivar2311 . Yep, I took the values from the link you've posted. I'll test the new example tomorrow and ;et you know. Thank you once again!
Hello!
I have changed the example once again.
onIncreaseColorTemperature
/ onDecreaseColorTemperature
now use std::next
and std::prev
to find the next / previous entry in the table.Please check with the latest update.
Hello.
Thank you. Sorry, but I have comments.
#include <ESP8266WiFi.h>
- i think this is obsolete. I believe this import is already done inside the SinricPro library.
And you also have a redundant comment // Change baudrate to your need for serial log
(it's added twice)
And the #include <Arduino.h>
import can be removed also.
I removed the mentioned imports and everything looks good. And seems to work correctly. At least with Google Home.
Hello and thanks for the testing and feedback.
Yes the (respectively) required WiFi library is already included by the SDK. But it doesn't hurt because it will be included only once. Removing the WiFi library would tend to confuse most users.
I will adjust the comment regarding the baud rate.
The include statement for Arduino.h is necessary if you don't work with ArduinoIDE but e.g. with PlatformIO.
Thanks for the explanation @sivar2311 !
The example was changed: a2bd364
RGB_LED_Stripe_5050.ino example incorrectly works with Google Home. Some of near white colours are handled by Sinric as a color temperature change, not the colour itself. So, we need to add the color temperature change handler here:
Can't create the PR unfortunately.