search

sinricpro / esp8266-esp32-sdk

Library for https://sinric.pro - simple way to connect your device to Alexa, Google Home, SmartThings and cloud
https://sinric.pro
Other
230 stars 124 forks source link

TV adjust volume callback #32

Closed nandemo closed 4 years ago

nandemo commented 4 years ago

Hello. Thank you for this amazing service! I've created a TV device and am handling the callbacks, but I've noticed that the "adjust volume" callback always gets a volumeDelta of 0. The "set volume" callback gets the correct volume, but "adjust volume" seems to get nothing for JsonObject request_value.

kakopappa commented 4 years ago

Ok will check and get back to you.

On Sat, 1 Feb 2020 at 1:24 PM nandemo notifications@github.com wrote:

Hello. Thank you for this amazing service! I've created a TV device and am handling the callbacks, but I've noticed that the "adjust volume" callback always gets a volumeDelta of 0. The "set volume" callback gets the correct volume, but "adjust volume" seems to get nothing for JsonObject request_value.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sinricpro/esp8266-esp32-sdk/issues/32?email_source=notifications&email_token=ABZAZZUUXRRV5LOHJXX4LYLRAUIRXA5CNFSM4KORIS22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IKJ6LZA, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZAZZTAUYMSHDIIJO5PZK3RAUIRXANCNFSM4KORIS2Q .

kakopappa commented 4 years ago

uploaded a fix. please check and let me know when you get a chance

nandemo commented 4 years ago

Wow, that was fast! It works perfectly now. Thank you very much!