search

sinshu / managed-doom

A Doom port written in C#
421 stars 62 forks source link

Enable nullables? #19

Open IceReaper opened 2 years ago

IceReaper commented 2 years ago

Ive enabled nullables on my local fork using <Nullable>enable</Nullable> While most warnings are pretty easy to fix, there seem to be several code locations where a particular value can actually be null, resulting in a crash. Would be making some PRS to implement the nullable concept (and maybe also going net6 and using stuff like <ImplicitUsings>enable</ImplicitUsings> or doing some code cleanups) be in interest?

sinshu commented 2 years ago

That sounds interesting. I've always wanted to modernize the code.

IceReaper commented 6 months ago

I just pushed the base of my Godot port in my fork. But before adding in the 3d renderer, I would like to refactor the codebase to .net8 using modern coding standards.

I have pushed an editor config file along with the directory build props file to enable style cop and enforce strict coding guidelines. This will likely completely break any backwards compatibility with this source repo, or in other words: I will need to manually port any future commit here.

Is there any interest in the changes I'm going to make? If you delete the managed doom/.editor config you will see what stuff I want to refactor. If the changes would be too heavy or non interesting, I'll go above approach and ditch the option to merge upstream changed.

One option would be to start with several features, especially the nullable implementation, and than make prs.

sinshu commented 6 months ago

Thanks for the suggestion.

Due to various circumstances, I currently don't have much time to work on this port. While modernizing the port is interesting, even something like enabling nullables involves significant changes, making it difficult to review and test them. Therefore, I believe it's best for your new project to proceed as an independent fork on your own.

I consider this port nearly complete with the functionalities I initially envisioned, and I see it as almost finished. While I'm going to continue with bug fixes and library updates, there will be no new features or major changes planned. Thus, manually catching up with this repo should be straightforward.