search

sinshu / rustysynth

A SoundFont MIDI synthesizer written in pure Rust
Other
108 stars 20 forks source link

No support for sf3 #4

Closed alters-mit closed 1 year ago

alters-mit commented 1 year ago

I tried using ms_basic.sf3 from MuseScore. Everything loads correctly but most of the presets sounds like bad white noise.

I converted ms_basic.sf3 to an sf2 file using Polyphone. rustysynth handles ms_basic.sf2 correctly.

Possibly, this is because sf3 uses ogg vorbis samples.

sinshu commented 1 year ago

To keep the code simple, I will not support SF3. However, it may be necessary to ensure that SF3 loading fails with an error.

sinshu commented 1 year ago

Made it so that loading SoundFont3 causes a SoundFontError::UnsupportedSampleFormat error to occur: https://github.com/sinshu/rustysynth/commit/2b3e9153fecdf9a3dad8b6d4ed8308561d08aaa3