search

sinshu / rustysynth

A SoundFont MIDI synthesizer written in pure Rust
Other
139 stars 22 forks source link

rust code formatting and clippy lints fixes #6

Closed joseluis closed 1 year ago

joseluis commented 1 year ago

Hi! Thank you very much for your wonderful crate.

I was playing with it and noticed it could benefit from some formatting and linting, which would help any other collaborations. I saw in #3 that you're open to PRs for making it more idiomatic so I went for it.

I've separated the changes in individual commits, in case you want to modify or explicitly ignore some. You can see the explanation for each lint in the clippy website, for example: vec_box.

sinshu commented 1 year ago

Thanks a lot for your awesome work on this PR! I really appreciate it 😄

I'll check it out and test it this weekend.

sinshu commented 1 year ago

I've merged the PR. Thank you 😄