search

sinsoku / gems_comparator

GemsComparator generates GitHub's compare view urls from Gemfile.lock
MIT License
9 stars 4 forks source link

no need to fork for parallel execution since this is network bound an… #2

Closed grosser closed 4 years ago

grosser commented 5 years ago

…d not cpu bound

parallel threading is easy, might as well not pull in another gem

@sinsoku

codecov[bot] commented 4 years ago

Codecov Report

Merging #2 into master will decrease coverage by 0.8%. The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage   99.56%   98.75%   -0.81%     
==========================================
  Files          10       10              
  Lines         228      241      +13     
==========================================
+ Hits          227      238      +11     
- Misses          1        3       +2
Impacted Files Coverage Δ
lib/gems_comparator/comparator.rb 95.23% <87.5%> (-4.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22e954f...da27f88. Read the comment docs.

grosser commented 4 years ago

updated

sinsoku commented 4 years ago

Thanks!