search

sintaxi / dbox

NodeJS SDK for Dropbox API (THIS LIBRARY IS OBSOLETE!!)
514 stars 91 forks source link

Fix scopePath on Windows #75

Open mikkotikkanen opened 10 years ago

mikkotikkanen commented 10 years ago

On windows the provided path slashes are "\" instead of "/"

jstroem commented 10 years ago

Shouldn't this bug be fixed using: http://nodejs.org/api/path.html#path_path_sep

mikkotikkanen commented 10 years ago

Well, it doesn't particularly matter. "\"-slashes break the regexp regardless.

pmoleri commented 8 years ago

I think the code shouldn't be using path at all, it's only using it to join dropbox paths instead of local paths. I would use a simple string join: var scopePath = scope[0] === "/" ? scope : "/" + scope;

CrackerakiUA commented 8 years ago

why this is not merged?