search

sintaxi / harp

Static Web Server/Generator/Bundler
http://harpjs.com
5k stars 343 forks source link

0.11.2: _ignoring _files or _folders with leading underscore, doesn't work with _test.less #228

Closed teamgroove closed 10 years ago

teamgroove commented 10 years ago

The expected harp-behaviour is, not try to compile those files. But it does. Even when i underscore the folder, harp goes there an tries to compile underscored files in an underscored folder. I have this issue with less-files. I am working with a /public/ dir. Example: When using: "/public/ less/ dontread.less", the file gets read and tried to be compiled. Maybe that is meant only to work for files, that are NOT in the public-directory?

kennethormandy commented 10 years ago

I’m pretty sure we have tests to make sure this doesn’t happen during harp server or harp compile, but it’s possible there’s a bug. I’m investigating.

Thanks very much for opening an issue and noting the version number. Any other details you can share would be greatly appreciated!

kennethormandy commented 10 years ago

Okay, so—we definitely need more tests here, but I can’t seem to recreate the behaviour you’re referring to. Is the problem that Harp opens the file? I believe this is expected, since these underscored files are generally partials by other LESS files during compilation. If that’s where the confusion is, we can improve the wording in the docs; really, they are not compiled directly, not ignored outright.

If the problem is that the _dontread.less file is actually ending up in your www directory after running harp compile, that is a bug. I will just need some more details to recreate it. Thanks for your help!

kennethormandy commented 10 years ago

Those files should be compiled (so they can be used as partials), but not served or put into the www directory if you run harp compile. @teamgroove, if that’s what happening and I’m misunderstanding, can you please let me know and re-open the issue? I’d really appreciate it.

Otherwise, I think everything is fine here, so I’m going to close the issue for now.

kennethormandy commented 10 years ago

@teamgroove Hey, we found another case like this. Is there any chance you’re running Windows 8.1?

kennethormandy commented 10 years ago

Hey there,

This issue should be fixed in Harp v0.12.0, which is now available! You can try it out after upgrading Harp with: npm upgrade -g harp

There’s a bunch of other new features, in and outside of the preprocessors, which we will be talking about in the Harp newsletter. You can subscribe here

Thanks for your continued help submitting and commenting on issues, we really appreciate it. If you are still having problems after upgrading, feel free to reopen this issue.

teamgroove commented 10 years ago

Hello, thank you. I can confirm that with ^0.12.0 the expected behaviour in the context of _files and _folders is correct now. btw, i <3 harp!

kennethormandy commented 10 years ago

Thanks @teamgroove! We’re happy it’s working out for you. Feel free to message us on Twitter if you ever have questions or want to share what you’re working on. Actually, it would be great to hear more specifically about how you’re using Harp, feel free to send me an email if you feel like chatting about it.