search

sintaxi / harp

Static Web Server/Generator/Bundler
http://harpjs.com
5k stars 346 forks source link

Update terraform@1.3.0's node-sass dependency to 4.1.1 #597

Closed Phenome closed 5 years ago

Phenome commented 7 years ago

I can now install harp on node 7.3.0. on windows, since node-sass 4.1.1 has a prebuilt binary for node 7.

Forced node-sass terraform dependency version to 4.1.1.

Phenome commented 7 years ago

---option 2: We close this PR, and I submit another PR on terraform to update its node-sass dependency, then wait for it to cascade back to harp (with more PRs?).

I'm not experienced with PRs, but love harp and would love to help.

sintaxi commented 7 years ago

Thanks for the help.

Ultimately what I would like to do is unbundle node-sass whiles till supporting it. So that harp doesn't by default have any binaries but if you use a .sass file it will still work as long as your project has node-sass installed. Does that make sense to you?

This could serve as a way for harp/terraform to support more preprocessors moving forward without the bloat. Any thoughts??

Phenome commented 7 years ago

That would be great :) I'll have to get more into the inner workings of harp to see where I could help. I'll give it some more thought and get back to it.

misterhtmlcss commented 5 years ago

@Phenome hey are you still interested in working more with Harp? We are gearing up to release 1.0 and we are currently discussing this particular issue you raised in your PR. Let me know if you want to join the conversation and get more involved.