fix optional parameters check in harp.compile()

sintaxi / harp

Static Web Server/Generator/Bundler

http://harpjs.com

5k stars 346 forks source link

fix optional parameters check in harp.compile() #614

Closed ccprog closed 5 years ago

ccprog commented 7 years ago

Code was assuming that if calling harp.compile(projectPath [,outputPath] [, callback]) with two parameters, the second is always a callback.

fixes #391

misterhtmlcss commented 5 years ago

@ccprog this looks to be still as valid today as it was many years ago when it was raised as an issue. Can you please retest this proposed change and confirm there are no issues with our current release and then resubmit. I'm going to close this and await your new PR please. Thank you for the PR and hopefully now that we are becoming more active we can count on you for more PRs going forward. Have a great Sunday!