Only use 'localhost' replacement for 127.0.0.1

sintaxi / harp

Static Web Server/Generator/Bundler

http://harpjs.com

5k stars 343 forks source link

Only use 'localhost' replacement for 127.0.0.1 #642

Closed jimjkelly closed 5 years ago

jimjkelly commented 6 years ago

As was discussed in issue #558, as Harp is now it is not possible to distinguish between an instance listening on localhost and any ip. This change fixes that.

Also adds tests to confirm behavior.

jimjkelly commented 6 years ago

Note that this is reopening of #578, as requested. I don't use harp anymore, so I couldn't extensively test this, but it's a pretty focused straight-forward change and I've added a couple tests to confirm functionality.

jimjkelly commented 5 years ago

I have to say it's pretty disheratening to be asked to resubmit a PR only to have it ignored a second time. I spent my free time on this, the second time around to try and better a project I don't even use anymore. Please don't solicit work if you are just going to ignore, it's a waste of both of our time.