sintaxi / surge

CLI for the surge.sh CDN
https://surge.sh
2.86k stars 136 forks source link

404 page not found when query params ends with file extension #290

Closed adriaandotcom closed 6 years ago

adriaandotcom commented 6 years ago

If I go to my website on surge to this URL: https://example.com/login?email=test@test.com, I get this error:

If I go to these URLs it does work as expected (no 404):

If I go to these URLs it does not work as expected (returns 404):

It looks like the path of the URL is being checked for a file extension, but also if it is a query parameter. It should only be checked when it is part of the filename.

I use a 200.html page to catch all the 404s which does not work, because I see the surge 404 page.

sintaxi commented 6 years ago

Thanks for the detailed report. Taking a look.

sintaxi commented 6 years ago

Just released a fix for this issue. Please let me know if you find any other problems.

adriaandotcom commented 6 years ago

Works for me now, thanks!