search

sintaxi / surge

CLI for the surge.sh CDN
https://surge.sh
2.86k stars 136 forks source link

Should exit with non-zero status if not configured #291

Open salomvary opened 6 years ago

salomvary commented 6 years ago

When surge is executed in non-interactive mode (eg. from a CI) and is not properly configured, it exits with zero status suggesting everything went well.

Expected: it should exit with non-zero status signalling a failure.

Version: 0.19.0

Steps to reproduce:

 $ echo "" | surge --project .

    Welcome to Surge! (surge.sh)
    Please login or create an account by entering your email and password:

              email: 
$ echo $?
0
buckle2000 commented 5 years ago

Somebody should fix this.

prashant-shahi commented 4 years ago

Need this!!