search

sintaxi / terraform

Asset pipeline for the Harp Web Server.
102 stars 101 forks source link

Feature/sourcemaps/all #121

Closed tjnicolaides closed 8 years ago

tjnicolaides commented 8 years ago

Per @sintaxi's request here https://github.com/sintaxi/terraform/pull/120#issuecomment-160206915 - all supported stylesheet preprocessors (less, sass, scss, and styl) receive uniform sourcemap implementation here.

Previous scss-only pull request: https://github.com/sintaxi/terraform/pull/120 Open issue in Harp: https://github.com/sintaxi/harp/issues/74#issuecomment-160199105

Please note that Stylus required an updated version in order to play ball here. I called it out in the commit -- I'm pretty ignorant of that particular preprocessor and would appreciate a second set of eyes as the error reporting appeared to have changed between the two versions. Tests are passing now but I'm not sure if anything else is amiss.

sintaxi commented 8 years ago

Very nice! Thanks.

sintaxi commented 8 years ago

Just merged. Will be part of Terraform v1.0.0 which will also include @johnboxall's clever #118 PR. Thanks for taking the time to put this together.