search

sintaxi / terraform

Asset pipeline for the Harp Web Server.
102 stars 101 forks source link

Update node-sass@v3.7.0 #130

Closed xzyfer closed 8 years ago

xzyfer commented 8 years ago

The current locked version, v3.4.2, is very old and no longer supported. It also does not support Node 6. This causing many people issues including harp users.

https://github.com/sintaxi/harp/issues/556

sintaxi commented 8 years ago

Thanks for taking a look at this.

kozie commented 8 years ago

If this could be merged, that would be nice 🤓 Than i don't have to downgrade my node 👍

kozie commented 8 years ago

Sorry to bother again but isn't it just a matter of merging the above PR into your branch to fix the whole Node 6.x issue for terraform and harp?

sintaxi commented 8 years ago

Thanks!

xzyfer commented 8 years ago

@sintaxi it's worth giving this article a read as this update my cause users code to start throwing errors if there were previously doing the wrong thing.

https://medium.com/@xzyfer/why-node-sass-broke-your-code-and-semver-1b3e409c57b9#.6jh3adpe0