search

sinzlab / mei

Visualize features cells are responsive to via gradient ascent.
MIT License
6 stars 8 forks source link

Bugs in quickstart demo notebook #36

Closed MaxFBurg closed 7 months ago

MaxFBurg commented 7 months ago

In the https://github.com/sinzlab/mei/blob/master/demo/quickstart.ipynb notebook, the cell

mei, final_evaluation, tracker_log = gradient_ascent(
    model=single_cell_model, config=method_config, seed=seed, shape=input_shape
)

fails: 

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[21], [line 1](vscode-notebook-cell:?execution_count=21&line=1)
----> [1](vscode-notebook-cell:?execution_count=21&line=1) mei, final_evaluation, tracker_log = gradient_ascent(
      [2](vscode-notebook-cell:?execution_count=21&line=2)     model=single_cell_model, config=method_config, seed=seed, shape=input_shape
      [3](vscode-notebook-cell:?execution_count=21&line=3) )

TypeError: gradient_ascent() got an unexpected keyword argument 'shape'
MaxFBurg commented 7 months ago

gradient_ascent also requires dataloaders to be passed

MaxFBurg commented 7 months ago

Ah sorry, did not yet use the newest version, actually works