search

sinzlab / sensorium

Code base for the SENSORIUM competition.
https://sensorium2022.net/
MIT License
59 stars 32 forks source link

Add compatibility with grid mean predictor #70

Closed KonstantinWilleke closed 2 years ago

KonstantinWilleke commented 2 years ago

plus additional cleanups

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

KonstantinWilleke commented 2 years ago

Thanks for the PR @KonstantinWilleke!

I looks good, and I just have one comment regarding the hub dataloader: Honestly, the more I think about it, the more I realize the hub dataloaders are unnecessary. However, if you want to use it and keep them it's fine with me. But let's avoid giving time-wise promises (e.g. dates, etc.) because we do not really know when the hub interface will become functional.

I'd still like to keep it, especially because we promised it in our proposal. But I agree that we should leave out the date and not make specific promises!