search

sio2project / oioioi

GNU General Public License v3.0
162 stars 72 forks source link

Fix class name shadow braking user change form in admin panel #245

Closed Xenox40 closed 1 year ago

Xenox40 commented 1 year ago

Closes #244.

This small change fixes the issue by renaming the class responsible for enforcing password confirmation when user wants to change its email address.

The UserChangeForm class introduced in https://github.com/sio2project/oioioi/commit/363ce7601719240a532cbe0585b6d57eaa70d393 https://github.com/sio2project/oioioi/blob/40a377d3f2d5cd9c94d01f03e197501ce4aab597/oioioi/base/forms.py#L235-L257 shadows the django one imported earlier https://github.com/sio2project/oioioi/blob/40a377d3f2d5cd9c94d01f03e197501ce4aab597/oioioi/base/forms.py#L8-L12 which is used as a base for admin's user change form https://github.com/sio2project/oioioi/blob/40a377d3f2d5cd9c94d01f03e197501ce4aab597/oioioi/base/forms.py#L266-L270

DietPawel commented 1 year ago

I rerun the tests, which pass in my local testing, just not here. This is simple change, which fixes a bug. I would appreciate merging it!

DietPawel commented 1 year ago

Thank You for quick reaction!