search

sio2project / oioioi

GNU General Public License v3.0
162 stars 72 forks source link

Implement easy import of schools from the ME #248

Open Igifigi opened 1 year ago

Igifigi commented 1 year ago

This PR implements an algorithm that will bring order to school selection in SIO. Implemented script is used to import schools from the RSPO database, which is provided by the Ministry of Education and contains all educational institutions in Poland. Due to the poor quality of this data, it is likely that SIO administrators will modify school data. The task of this script is to detect which corrections from newer and more recent versions of the RSPO database should be accepted and applied, and which should not.

twalen commented 1 year ago

some more verbose commit messages might be useful (instead of "temp commit")

Igifigi commented 1 year ago

some more verbose commit messages might be useful (instead of "temp commit")

As you can see, this PR is set as a draft, so commit names will be changed soon (probably tomorrow).

Igifigi commented 1 year ago

@twalen now it's ready for review :))

DietPawel commented 1 year ago

I am missing some migration related trickery to allow migrating a database with existing schools lacking rspo fields. As well as I am not sure it is right to get rid of legacy non-rspo csv import.