CMake does not check for needed dependencies during configuration

sio2project / sio2jail

A tool for supervising execution of programs submitted in algorithmic competitions

MIT License

29 stars 10 forks source link

CMake does not check for needed dependencies during configuration #5

Closed Michcioperz closed 5 years ago

Michcioperz commented 5 years ago

mkdir build; cd build; cmake .. proceeds perfectly well on a system without libseccomp-dev and libtclap-dev. I think CMake should get to yell about this during config and not during build.

Wolf480pl commented 5 years ago

We download and build libseccomp on our own, during the build process. Not sure about libtclap.

Michcioperz commented 5 years ago

libseccomp-dev is still needed. Telling CMake to link target to library only makes it add -llibrary, it doesn't do anything to ensure the headers are there. libcap-dev is also part of the problem.

teqwve commented 5 years ago

AFAIK libseccomp should worked at the time. Nevertheless, in v1.1.1, we've introduced some changes in build system that address Your issues.