search

siom79 / japicmp

Comparison of two versions of a jar archive
https://siom79.github.io/japicmp
Apache License 2.0
712 stars 107 forks source link

New default method should be binary compatible #221

Closed viktorsomogyi closed 6 years ago

viktorsomogyi commented 6 years ago

According to Oracle's documentation on https://docs.oracle.com/javase/specs/jls/se8/html/jls-13.html#jls-13.5.6 adding a new default method should be binary compatible.

viktorsomogyi commented 6 years ago

Hi @siom79, I've tried out your library and it looks cool!

At a certain point I found something which I think is a bug. According to Oracle's documentation adding a new default method should be binary compatible (but not source compatible) but the report generates it as incompatible. I looked it up the code and changed it. Please review it and merge if it looks good and you also think it is a bug.

viktorsomogyi commented 6 years ago

As per #201 I'm closing this PR. If needed users can find a workaround by adding a compatibility change override.