siom79 / japicmp

Comparison of two versions of a jar archive
https://siom79.github.io/japicmp
Apache License 2.0
712 stars 107 forks source link

skip plugin execution parameter does not work #262

Closed arvindkrishnakumar-okta closed 4 years ago

arvindkrishnakumar-okta commented 4 years ago

Read the doc at https://siom79.github.io/japicmp/MavenPlugin.html and tried to use the skip parameter in the plugin configuration.

`

com.github.siom79.japicmp
                <artifactId>japicmp-maven-plugin</artifactId>
                <version>0.14.3</version>
                <configuration>
                    <parameter>
                        <skip>true</skip>
                        <onlyModified>true</onlyModified>
                    </parameter>
                </configuration>`

maven throws the below error:

[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.14.3:cmp (japicmp) on project okta-sdk-api: Unable to parse configuration of mojo com.github.siom79.japicmp:japicmp-maven-plugin:0.14.3:cmp for parameter skip: Cannot find 'skip' in class japicmp.maven.Parameter -> [Help 1]

maven version used: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T11:41:47-07:00).

According to the docs, this param should work from Maven 3.0.3 onwards?

siom79 commented 4 years ago

Yes, the parameter should work. But it is now located inside the <configration> block and no longer inside the <parameter> block.