search

siom79 / japicmp

Comparison of two versions of a jar archive
https://siom79.github.io/japicmp
Apache License 2.0
712 stars 107 forks source link

Allow >1 compatibility change to be configured in one go #299

Open garydgregory opened 3 years ago

garydgregory commented 3 years ago

Hi JApiCmp,

Are you interested in a patch that allows:

              <overrideCompatibilityChangeParameter>
                <compatibilityChange>A, B, C</compatibilityChange>
                <binaryCompatible>true</binaryCompatible>
                <sourceCompatible>true</sourceCompatible>
              </overrideCompatibilityChangeParameter>

Instead of:

              <overrideCompatibilityChangeParameter>
                <compatibilityChange>A</compatibilityChange>
                <binaryCompatible>true</binaryCompatible>
                <sourceCompatible>true</sourceCompatible>
              </overrideCompatibilityChangeParameter>
              <overrideCompatibilityChangeParameter>
                <compatibilityChange>B</compatibilityChange>
                <binaryCompatible>true</binaryCompatible>
                <sourceCompatible>true</sourceCompatible>
              </overrideCompatibilityChangeParameter>
              <overrideCompatibilityChangeParameter>
                <compatibilityChange>C</compatibilityChange>
                <binaryCompatible>true</binaryCompatible>
                <sourceCompatible>true</sourceCompatible>
              </overrideCompatibilityChangeParameter>

?

siom79 commented 3 years ago

If you are willing to do it, you can do it. It will reduce configuration overhead.

Gary Gregory @.***> schrieb am Do., 14. Okt. 2021, 14:26:

Hi JApiCmp,

Are you interested in a patch that allows:

          <overrideCompatibilityChangeParameter>
            <compatibilityChange>A, B, C</compatibilityChange>
            <binaryCompatible>true</binaryCompatible>
            <sourceCompatible>true</sourceCompatible>
          </overrideCompatibilityChangeParameter>

Instead of:

          <overrideCompatibilityChangeParameter>
            <compatibilityChange>A</compatibilityChange>
            <binaryCompatible>true</binaryCompatible>
            <sourceCompatible>true</sourceCompatible>
          </overrideCompatibilityChangeParameter>
          <overrideCompatibilityChangeParameter>
            <compatibilityChange>B</compatibilityChange>
            <binaryCompatible>true</binaryCompatible>
            <sourceCompatible>true</sourceCompatible>
          </overrideCompatibilityChangeParameter>
          <overrideCompatibilityChangeParameter>
            <compatibilityChange>C</compatibilityChange>
            <binaryCompatible>true</binaryCompatible>
            <sourceCompatible>true</sourceCompatible>
          </overrideCompatibilityChangeParameter>

?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/siom79/japicmp/issues/299, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4U7NAMG564DF2YUDI4DD3UG3D6VANCNFSM5F7RCLKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.