Refine `CONSTRUCTOR_LESS_ACCESSIBLE` evaluation

[scordio]

Fixes #310.

A compatibility change is reported only when:

• The class is not final
• The class is final but the constructor was public

All the other cases are considered binary/source compatible changes.

[scordio]

Working on this change I noticed that the test framework is JUnit 4 and assertions have quite some boilerplate.

If desirable, in separate PRs I could help with:

• Upgrading to Junit Jupiter, the @ParameterizedTest feature would be a great addition for tests of japicmp.
• Using AssertJ to improve assertion readability (I'm clearly biased about it 😉).

[scordio]

I guess the build failure is unrelated to my changes and probably caused by 6ca79cfaf8de15f46172e539566169c8b0997217, right?

[siom79]

Exactly. I am trying to fix the build failure. Afterwards I will merge your commit.

Am Sa., 29. Jan. 2022 um 12:41 Uhr schrieb Stefano Cordio < @.***>:

I guess the build failure is unrelated to my changes and probably caused by 6ca79cf https://github.com/siom79/japicmp/commit/6ca79cfaf8de15f46172e539566169c8b0997217, right?

— Reply to this email directly, view it on GitHub https://github.com/siom79/japicmp/pull/311#issuecomment-1024895040, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4U7NAEORUYOEQMHFGXOKTUYPG5ZANCNFSM5MEHPHYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

[scordio]

Just raised #313 about it.