search

siom79 / japicmp

Comparison of two versions of a jar archive
https://siom79.github.io/japicmp
Apache License 2.0
694 stars 107 forks source link

htmlTitle not actually added to html file #362

Closed bradleylarrick closed 10 months ago

bradleylarrick commented 10 months ago

I found that when generating the japicmp report during the site phase of a maven build, the specified htmlTitle value was not actually added to the resulting html file. As a result the browser tab and breadcrumb only contained the project name. I resolved the issues by adding the following code the executeReport() in JApiCmpReport.java:

Sink sink = getSink();
sink.head();
String title = pluginParameters.getParameterParam().getHtmlTitle();
if (title != null) {
    sink.title();
    sink.text(title);
    sink.title_();
}
sink.head_();
sink.rawText(htmlString);
sink.close();
siom79 commented 10 months ago

Fixed. Will be part of the next release.

bradleylarrick commented 10 months ago

Confirmed. Thanks for the quick response!