siom79 / japicmp

Comparison of two versions of a jar archive
https://siom79.github.io/japicmp
Apache License 2.0
694 stars 107 forks source link

False positive when on a final class protected method made into private #367

Open cstamas opened 8 months ago

cstamas commented 8 months ago

If there is a method w/ protected access on a final class, making that method into private triggers source incompatibility.

While the change lessen accessibility of the method from the package (call it "api"), is this really breaking compatibility with client code?

cstamas commented 8 months ago

Also, having protected method on final class does not make much sense, but it happened.

As I reported: