search

sionescu / iolib

Common Lisp I/O library
http://common-lisp.net/project/iolib/
MIT License
141 stars 31 forks source link

Make epoll-multiplexer thread safe #28

Open attila-lendvai opened 9 years ago

attila-lendvai commented 9 years ago

Instead of a preallocated slot use WITH-FOREIGN-OBJECT to allocate the events array, and thus make HARVEST-EVENTS safe for concurrent calls.

attila-lendvai commented 7 years ago

@sionescu, what's the deal with this? shall i rebase it? will you merge it?

i need it in our production systems and it's a headache to keep it in sync with master.

attila-lendvai commented 6 years ago

@sionescu any decision on this? do you theoretically agree to this?

i understand if you have no time to deal with it right now. i just want to know what to expect in the future, because we need to maintain a separate repo for this single patch to build our production systems (as opposed to simply getting iolib from quicklisp).

attila-lendvai commented 4 years ago

i had to rebase this, it should merge fine into the current master.

darabi commented 3 years ago

Hi @sionescu,

as a hu.dwim.web-server user, I'm also interested in this patch. Will it be merged some time soon or should it be implemented differently?

Thank you

attila-lendvai commented 6 months ago

@sionescu i'm still maintaining this several years later, but it's quite a straightforward patch: it just moves the allocation of the buffer to the thread instead of a shared slot on the object. and i doubt it has serious performance implications.

any reason this is still not merged?

this was needed to fix an actually manifesting bug in our webapps.