search

sipa / bech32

Code snippets and analysis of the Bech32 format
191 stars 107 forks source link

Add C# reference implementation #20

Closed NicolasDorier closed 6 years ago

NicolasDorier commented 7 years ago

Implement Bech32 with error detection in C#.

NicolasDorier commented 7 years ago

@sipa can you merge that ?

NicolasDorier commented 7 years ago

Updated and fixed the tests

NicolasDorier commented 7 years ago

Anything left for merging ?

sipa commented 6 years ago

@NicolasDorier Sorry for the slow response here...

I would rather avoid having the full error location logic in the reference implementation (which is intended to be lean and understandable, and easily copy-pastable and into your own project). There is a separate ecc directory for the error correction code.

NicolasDorier commented 6 years ago

Removed code error correction code

P33LLo commented 6 years ago

Pay P33LL0

NicolasDorier commented 6 years ago

Thanks @Coding-Enthusiast , fixed.

NicolasDorier commented 6 years ago

@sipa do you intend to merge this one day?

NicolasDorier commented 6 years ago

Spring cleaning, ping me if you feel like merging.