sipa / bech32

Code snippets and analysis of the Bech32 format
191 stars 107 forks source link

Add java ref implementation #40

Open erasmospunk opened 6 years ago

sneurlax commented 6 years ago

Duplicate of #19 ?

erasmospunk commented 6 years ago

@sneurlax #19 had no updates from July. This tries to be as close to the C++ code as possible and uses byte arrays for higher efficiency. Also it it uses logical right shifts (>>>) and is careful with java byte to int sign extensions.

erasmospunk commented 6 years ago

@sipa could you provide some feedback if anything is needed to merge this?

schildbach commented 6 years ago

I'm now in the process of integrating this code into bitcoinj.

erasmospunk commented 5 years ago

Hey @sipa, care to check this PR for merging?