search

sipa / bips

Bitcoin Improvement Proposals
bitcoin.org
145 stars 43 forks source link

bip-0141: link CastToBool to definition source file #141

Closed jonatack closed 4 years ago

jonatack commented 4 years ago

as per discussion at http://www.erisian.com.au/taproot-bip-review/log-2019-11-12.html#l-110.

The rendered mediawiki may be tested by viewing https://github.com/jonatack/bips/blob/bip141-CastToBool-link-to-definition/bip-0141.mediawiki.

On the side, remove extra whitespaces.

I am unsure whether it is better to submit the PR here, or in bitcoin/bips.

sipa commented 4 years ago

I don't think we should be modifying other BIPs in this repo. You can submit it instead directly to the upstream bips repo, though.

I think it's better to specify in text what the semantics of CastToBool are. If you link to the code it should probably be with a stable link (using the master branch means things may go out of date).

jonatack commented 4 years ago

Thank you @sipa for reviewing. Good points.