search

sipa / bips

Bitcoin Improvement Proposals
bitcoin.org
145 stars 43 forks source link

Nit: bip-schnorr: Add missing dots that denote multiplication #151

Closed dgpv closed 5 years ago

dgpv commented 5 years ago

Throughout the document, multiplication is denoted with dots, as in d'⋅G as opposed to d'G. This is not the case in two places in the 'Default Signing' section.

Missing dots are added for consistency.

dgpv commented 5 years ago

I had doubts about adding dot for scalar multiplication, but I also noticed that there's potential ambiguity for sk and ed, and added the dot in ed to bring attention to this issue.

I will remove the dot in e⋅d in this PR - I think that it is better to use one-char names instead of sk and pk to avoid ambiguity vs scalar multiplication, but I do not have good candidate names for them.

sipa commented 5 years ago

ACK