sipa / bips

Bitcoin Improvement Proposals
bitcoin.org
145 stars 43 forks source link

Switch to even-y tiebreaker for pubkeys #192

Closed sipa closed 4 years ago

sipa commented 4 years ago

Addresses #191.

TODO: adjust reference code, but we'll probably only want to do that after addressing #190 as well.

real-or-random commented 4 years ago

Concept ACK, looks good except nits. :)

ajtowns commented 4 years ago

Can you define &?

Saying ** The function ''is_even(P)'', where ''P'' is a point, returns ''y(P) = 0 mod 2''. should work, we've already got blah ≠ 0 mod p elsewhere.

Should we call this evenness instead of oddness?

We only use "oddness" once when talking about choosing which R point, so doesn't seem worth worrying about to me.

sipa commented 4 years ago

Changed things a bit.

real-or-random commented 4 years ago

ACK :)

ajtowns commented 4 years ago

ACK

sipa commented 4 years ago

Fixed a few more remaining mentions of "point".