Fix a few minor issues - Githubissues

sipa / bips

Bitcoin Improvement Proposals

bitcoin.org

145 stars 43 forks source link

Fix a few minor issues #199

Closed real-or-random closed 4 years ago

real-or-random commented 4 years ago

Recommend a byte length for aux random data
Clarify that with signature verification by default at the end of the signing algorithm, using public keys from untrusted sources is not an issue.
A few editorial nits

sipa commented 4 years ago

ACK

real-or-random commented 4 years ago

I changed it to only 32 bytes aux data but I'm not really convinced because now we say a lot about padding byte arrays to 32 bytes. This seems like an artificial restriction now. I liked the other variant more, I think.

real-or-random commented 4 years ago

Ok, then let's keep it. :) I forced-push to change "constant bytes" to "null bytes" as suggested elsewhere. (And didn't want to write "zero bytes" because I always read this as "0 bytes". :D)

jonasnick commented 4 years ago

@sipa is this ready to merge?