search

sipa / bips

Bitcoin Improvement Proposals
bitcoin.org
143 stars 43 forks source link

BIP-0340: Miscellaneous fixups #206

Closed jonasnick closed 4 years ago

jonasnick commented 4 years ago

This is a result of Alan Szepieniec feedback and @sipa's responses.

sipa commented 4 years ago

Concept ACK. As these BIPs are already published, PR it directly to https://github.com/bitcoin/bips ?

jonasnick commented 4 years ago

I was thinking that there may be more changes to the BIP soon (#195 #204 #205) and it would be simpler to merge them here first and then PR them against upstream all at once. At least this is what we did last time.

sipa commented 4 years ago

@jonasnick Sounds good.

sipa commented 4 years ago

Also ping @aszepieniec.

sipa commented 4 years ago

ACK