search

sipa / bips

Bitcoin Improvement Proposals
bitcoin.org
145 stars 43 forks source link

Remove segwit v0 scriptPubKeys from valid test vectors #218

Closed benthecarman closed 3 years ago

benthecarman commented 3 years ago

Since bech32m is not meant for sewit v0, it doesn't really make sense to have test vectors for it.

sipa commented 3 years ago

I strongly believe it's better to keep this.

This BIP isn't just specifying addresses for v1+, but all segwit addresses (where v0 just happens to reuse bech32 unchanged). E.g. the code snippets also explain how to deal with v0.

I don't want to let it up to implementers to determine exactly what subset of BIP173 remains valid, and what part is intentionally changing. You should be able to implement the test vectors listed here and be done with it.

benthecarman commented 3 years ago

I originally thought these were bech32m addresses on segwitv0 spks. Now I see that these are bech32 addresses