sipa / bips

Bitcoin Improvement Proposals
bitcoin.org
145 stars 43 forks source link

bip-340: reduce size of randomizers to 128 bit and provide argument #220

Closed jonasnick closed 2 years ago

jonasnick commented 3 years ago

This speeds up batch verification in libsecp by up to 9%.

I can open this upstream if people are happy with this PR.

CC @real-or-random

real-or-random commented 3 years ago

@jonasnick Oh there's also #204, which anyway will require touching those sentences again...

Maybe it's better to convert the "generate random integers" paragraph also more to pseudocode-like thing. The text is already complex now and #204 won't make it simpler. I'd volunteer to give it a try when resolving #204.

Having said that, do you think it makes sense to batch some of open issues, i.e., solve them here in this repo and then open a PR to the official BIPs repo? I know I haven't worked on this for a while but maybe now is a good time to focus on this again and then we can solve all or at least most of the changes quickly. None of the issues here should require a lengthy discussion. The discussions already happened, we just need to write down the results.

jonasnick commented 3 years ago

I'm fine with batching as long as completing the batch doesn't takevery long. We should try avoiding blocking our own implementation work with batching.

real-or-random commented 3 years ago

Note (sorry for abusing this PR but this is the best place to note):